Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking out main with Maintenance.checkoutBranch() #320

Open
zepumph opened this issue May 5, 2023 · 0 comments
Open

Allow checking out main with Maintenance.checkoutBranch() #320

zepumph opened this issue May 5, 2023 · 0 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented May 5, 2023

Right now you get an error because master isn't a modified branch (ever)

maintenance> m.checkoutBranch( 'my-solar-system', 'master' )
Maintenance task failed:
Error: Could not find a tracked modified branch for my-solar-system master
    at Maintenance.ensureModifiedBranch (C:\Users\mjkauzmann\PHET\git\perennial\js\common\Maintenance.js:1259:17)
    at Maintenance.checkoutBranch (C:\Users\mjkauzmann\PHET\git\perennial\js\common\Maintenance.js:681:48)
    at REPL8:2:3
    at Script.runInContext (node:vm:141:12)
    at defaultEval (node:repl:574:29)
    at bound (node:domain:433:15)
    at runBound (node:domain:444:12)
    at session.eval (C:\Users\mjkauzmann\PHET\git\perennial\js\common\Maintenance.js:1175:11)
    at REPLServer.onLine (node:repl:902:10)
    at REPLServer.emit (node:events:513:28)

@jonathanolson can we add support for not checking ensureModifiedBranch if the target branch is master?

@zepumph zepumph assigned zepumph and jonathanolson and unassigned zepumph May 5, 2023
@zepumph zepumph changed the title Allow checking out master with Maintenance.checkoutBranch() Allow checking out main with Maintenance.checkoutBranch() Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants