Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator: Change Description/Speech component to speak() instead of return string #172

Open
brettfiedler opened this issue Oct 16, 2023 · 8 comments
Assignees

Comments

@brettfiedler
Copy link
Contributor

JG and BF noted it might be simpler to have speech mimic the Sound component view by calling a "speak()" function instead of returning a string.

To discuss at next design meeting

@brettfiedler
Copy link
Contributor Author

Assuming this is also small, let's do this in tandem with #170.

@brettfiedler
Copy link
Contributor Author

brettfiedler commented Sep 6, 2024

@jessegreenberg noted that this will break a lot of programs. Let's.. not do this right now. Instead, can we indicate somewhere in the Control Function for the Speech component:

Your custom function must return a string in order to play speech. For example: `return "Hello World!"`

@jessegreenberg
Copy link
Contributor

OK, done in the above commit. If we do have some time, this would be good to do before an initial 'release'.

@brettfiedler
Copy link
Contributor Author

We decided that earlier is better than later. So let's go ahead with it!

@jessegreenberg
Copy link
Contributor

OK, progress on this in the above commits. It is done on the dev branch but I need to update more usages. While working on this I found and fixed two bugs that blocked progress here - a bug saving templates (with bad characters in the template name) using the local data service, and a bug loading speech components because of #251 (comment).

Next, need to start over on changing return 'string' to speak( 'string' )

@jessegreenberg
Copy link
Contributor

Ok, I have updated all templates and projects in the remote database to use speak() instead of return string.

Next, will need to do the same for the local templates and default projects, but that should be easier.

@jessegreenberg
Copy link
Contributor

Alright, I think we are finally there. Since projects on the remote database need these changes to work correctly I am going to go ahead and merge dev into main.

@jessegreenberg
Copy link
Contributor

@brettfiedler this is done. I tried to test as much as I could, but since I had to edit a lot of projects this is one that could introduce a bug.

Assigning to you in case you want to verify anything or feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants