Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min and Max mass listed don't take material into consideration #407

Open
KatieWoe opened this issue Sep 16, 2024 · 7 comments
Open

Min and Max mass listed don't take material into consideration #407

KatieWoe opened this issue Sep 16, 2024 · 7 comments
Assignees
Labels
dev:phet-io type:bug Something isn't working

Comments

@KatieWoe
Copy link

Device
Samsung
OS
Win 11
Browser
Chrome
Problem Description
For phetsims/qa#1141
In studio, the mass ranges given for blocks may not take into account the material the block is currently made of. For example, the range for buoyancy.exploreScreen.view.blockAPanel.massNumberControl.massProperty is .1-27, but depending on the material is usually smaller than that.

Visuals
setvaluegivenwrong

@KatieWoe KatieWoe added the type:bug Something isn't working label Sep 16, 2024
@KatieWoe
Copy link
Author

Actually, this looks like it's already addressed in the examples doc, so it can probably be closed.

@Nancy-Salpepi
Copy link

I asked about this same thing in the Buoyancy slack channel!
Here is the response:

Sam Reid
My understanding is that the range shown there (at the bottom) is the total composite range for any material. It is static and unchanging, whereas the enabledRange is able to change. But studio (at the bottom) is supposed to show the static range, not the dynamic enabledRange.

Kathy Perkins
@arouinfar should weigh in on this question as well.

Amy Rouinfar

Yes, that behavior is fine. The examples clarifies that resultant volume needs to be 1-10L and recommends clients first refer to enabledRangeProperty before setting mass.

Nancy Salpepi

Wondering if that statement in the examples should come before the massProperty phetio IDs or do you think it is OK as is
@arouinfar?

@KatieWoe
Copy link
Author

I noticed this discrepancy with the mystery fluids, which doesn't make sense to me.
fluidcbounds

@Nancy-Salpepi
Copy link

@KatieWoe your last comment is part of issue #405

@KatieWoe
Copy link
Author

Ahh, thanks

@zepumph
Copy link
Member

zepumph commented Oct 1, 2024

Ok great. Yes I believe all the actionables are in #405 and examples.md. Closing.

@zepumph zepumph closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@zepumph zepumph added the type:wontfix This will not be worked on label Oct 1, 2024
@zepumph
Copy link
Member

zepumph commented Oct 1, 2024

Oh, we need to update examples. @arouinfar can you add this sentiment from the above comment:

Wondering if that statement in the examples should come before the massProperty phetio IDs or do you think it is OK as is
@arouinfar?

@zepumph zepumph reopened this Oct 1, 2024
@zepumph zepumph added dev:phet-io and removed type:wontfix This will not be worked on labels Oct 1, 2024
@zepumph zepumph assigned arouinfar and unassigned samreid and zepumph Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:phet-io type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants