Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to set Earth's gravity outside of range #406

Open
Nancy-Salpepi opened this issue Sep 16, 2024 · 1 comment
Open

Able to set Earth's gravity outside of range #406

Nancy-Salpepi opened this issue Sep 16, 2024 · 1 comment
Labels
meeting:design type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.6.1

Browser
Safari 17.6

Problem description
For phetsims/qa#1141, when using the query parameter ?gEarth, the possible range is between 9-10. In studio, I am able to set the range for Earth between 0.1 and 25 without getting an error or popup message.

Steps to reproduce

  1. In studio go to the Lab screen
  2. Change the value of buoyancy.global.model.gravities.earth.gravityValueProperty to 4.

Visuals
Screenshot 2024-09-16 at 1 31 24 PM

@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Sep 16, 2024
@zepumph
Copy link
Member

zepumph commented Oct 1, 2024

Let's double check with designers, I bet that it would be fine to increase the range of the query parameter. It is also easy to change the numberProperty range just for earth (or make them all different). Let's talk to designers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting:design type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants