Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to custom.densityProperty in examples.md #400

Open
Nancy-Salpepi opened this issue Sep 13, 2024 · 2 comments
Open

Changes to custom.densityProperty in examples.md #400

Nancy-Salpepi opened this issue Sep 13, 2024 · 2 comments
Assignees

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#1141, the following PhET-iO IDs were made readOnly=true in work done here..

The examples.md doesn't reflect these changes and I'm not sure that @arouinfar was aware that these properties were changed.

Density:

density.introScreen.model.blocks.blockA.materialProperty.customMaterial.densityProperty
density.introScreen.model.blocks.blockB.materialProperty.customMaterial.densityProperty

Buoyancy:

buoyancy.exploreScreen.model.blocks.blockA.materialProperty.customMaterial.densityProperty
buoyancy.exploreScreen.model.blocks.blockB.materialProperty.customMaterial.densityProperty
buoyancy.labScreen.model.block.materialProperty.customMaterial.densityProperty
buoyancy.applicationsScreen.model.objects.block.materialProperty.customMaterial.densityProperty

@arouinfar
Copy link

Thanks @Nancy-Salpepi. This will be a fairly major rewrite, as customMaterial.densityProperty is hardly ever editable. I'll wait until after the RC testing is complete to address this issue, in case other issues arise.

@arouinfar
Copy link

QA for rc.1 is now complete, so I'll start working on these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants