Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document transformations #6

Open
perone opened this issue Oct 14, 2018 · 4 comments
Open

Document transformations #6

perone opened this issue Oct 14, 2018 · 4 comments
Labels
documentation Related to documentation good first issue Good for newcomers

Comments

@perone
Copy link
Owner

perone commented Oct 14, 2018

There are many transformations, such as transforms.Resample and transforms.ElasticTransform that aren't documented (with the Sphinx format).

@perone perone added good first issue Good for newcomers documentation Related to documentation labels Oct 14, 2018
@MohitTare
Copy link
Contributor

MohitTare commented Nov 19, 2018

Thanks for this wonderful project. I was exploring the library and I tried to make a example notebook on how to create a dataloader using medicaltorch. Will try to work on the documentation part also.

Any thing else we can contribute on ? Also please share your reviews on the notebook so that we can improve on it if needed.

@perone
Copy link
Owner Author

perone commented Nov 20, 2018

Thank you @MohitTare, that is a very nice notebook, you definitely captured the idea of how the transformations and loaders are structured. What is nice is that you show how the input and gt keys work. Let me know when you want to merge the notebook, and please add a link to it from the main documentation or readme so people will be able to find it easily.

@MohitTare
Copy link
Contributor

Thanks @perone for checking the notebook out. I have generated a PR. You can review once and let me know in case of any changes (PS: i am a bit new to the open source contributions, but willing to contribute more !)

@perone
Copy link
Owner Author

perone commented Nov 20, 2018

Thanks for the contribution @MohitTare, I just merged it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants