Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13282 Migrate pmm-dump to v3 #3143

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Aug 8, 2024

PMM-13282

Link to the Feature Build: SUBMODULES-3687

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

Please note, we are aligning pmm-dump's version with PMM Server's.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.54%. Comparing base (a068394) to head (9dffab2).
Report is 27 commits behind head on v3.

Files with missing lines Patch % Lines
managed/services/dump/dump.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3143      +/-   ##
==========================================
+ Coverage   44.51%   44.54%   +0.03%     
==========================================
  Files         357      357              
  Lines       35670    35670              
==========================================
+ Hits        15878    15890      +12     
+ Misses      18165    18154      -11     
+ Partials     1627     1626       -1     
Flag Coverage Δ
admin 11.52% <ø> (+0.05%) ⬆️
agent 52.79% <ø> (+0.13%) ⬆️
managed 46.64% <0.00%> (-0.01%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review August 10, 2024 07:16
@ademidoff ademidoff requested a review from a team as a code owner August 10, 2024 07:16
@ademidoff ademidoff requested review from BupycHuk, idoqo and JiriCtvrtka and removed request for a team August 10, 2024 07:16
@ademidoff ademidoff merged commit 0734b92 into v3 Sep 19, 2024
28 checks passed
@ademidoff ademidoff deleted the PMM-13282-migrate-pmm-dump-to-v3 branch September 19, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants