-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBM-1143] Add support for WebDAV backups #855
Conversation
eacadde
to
ce24bc4
Compare
What's missing to this PR is maybe an integration test? Maybe it's not obvious to me how to do that. |
try to add it here percona-backup-mongodb/e2e-tests/cmd/pbm-test/run.go Lines 28 to 31 in 86d5528
|
OK, then I need to fire up a WebDAV server, as I can't rely on a external service like S3 or Azure. |
to run the test: on Apple Silicon you can try: |
fdc373d
to
68ea534
Compare
Although it's all green, I am not sure if what I pushed actually run the E2E test for WebDAV 🤨 Speaking of E2E setup, I'm wondering if this choice of
In the sense that:
For example, I only committed to |
Hi @dalbani, just for me to better understand the use-case of WebDAV in 2023. In which scenario and where do you actually need WebDAV? Can you elaborate a little more on your needs? Thanks, |
Well, even though it's 2023, WebDAV is very much "alive".
And there are other (open source) implementations of WebDAV servers available for self-hosted deployments. |
Hey, we've investigated and surveyed our current customer base, and there isn't genuine interest in WebDAV. Given that we need to maintain the code for a very long time, given support and SLAs, we don't consider adding it to the project. So I'll close this PR, so you don't wait any longer on a decision that might never happen. Nevertheless thanks a lot for the contribution. |
Thanks for your feedback. |
https://jira.percona.com/browse/PBM-1143