Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBM-1143] Add support for WebDAV backups #855

Closed
wants to merge 4 commits into from

Conversation

dalbani
Copy link
Contributor

@dalbani dalbani commented Jul 9, 2023

@dalbani dalbani requested a review from defbin as a code owner July 9, 2023 16:13
@dalbani dalbani marked this pull request as draft July 9, 2023 16:14
@dalbani dalbani force-pushed the PBM-1143 branch 3 times, most recently from eacadde to ce24bc4 Compare July 9, 2023 18:47
@dalbani
Copy link
Contributor Author

dalbani commented Jul 11, 2023

What's missing to this PR is maybe an integration test? Maybe it's not obvious to me how to do that.

@defbin
Copy link
Member

defbin commented Jul 11, 2023

try to add it here

{"AWS", "/etc/pbm/aws.yaml"},
{"GCS", "/etc/pbm/gcs.yaml"},
{"Azure", "/etc/pbm/azure.yaml"},
{"FS", "/etc/pbm/fs.yaml"},

@dalbani
Copy link
Contributor Author

dalbani commented Jul 11, 2023

OK, then I need to fire up a WebDAV server, as I can't rely on a external service like S3 or Azure.

@defbin
Copy link
Member

defbin commented Jul 11, 2023

to run the test:
env MONGODB_VERSION=6.0 TESTS_BCP_TYPE=logical e2e-tests/run-all

on Apple Silicon you can try:
env MONGODB_VERSION=6.0.6-arm64 TESTS_BCP_TYPE=logical e2e-tests/run-all

@dalbani dalbani force-pushed the PBM-1143 branch 3 times, most recently from fdc373d to 68ea534 Compare July 12, 2023 16:32
@dalbani
Copy link
Contributor Author

dalbani commented Jul 12, 2023

Although it's all green, I am not sure if what I pushed actually run the E2E test for WebDAV 🤨

Speaking of E2E setup, I'm wondering if this choice of path-ignores is correct:

In the sense that:

When all the path names match patterns in paths-ignore, the workflow will not run. If any path names do not match patterns in paths-ignore, even if some path names match the patterns, the workflow will run.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths

For example, I only committed to e2e-tests/pkg/tests/sharded/cluster.go in 96b095e, and, yet, CI ran.

@defbin defbin added community feature new feature labels Jul 13, 2023
@dalbani dalbani marked this pull request as ready for review July 16, 2023 16:28
@ImTheKai
Copy link
Collaborator

Hi @dalbani,

just for me to better understand the use-case of WebDAV in 2023. In which scenario and where do you actually need WebDAV? Can you elaborate a little more on your needs?

Thanks,
Kai

@dalbani
Copy link
Contributor Author

dalbani commented Jul 24, 2023

Well, even though it's 2023, WebDAV is very much "alive".
I can name for example two storage providers which offer WebDAV-backed repositories — and no S3 compatible endpoint:

  • Hetzner Storage Box
  • Microsoft OneDrive — yep, it's technically possible to connect via WebDAV, you can look it up 😃

And there are other (open source) implementations of WebDAV servers available for self-hosted deployments.

@ImTheKai
Copy link
Collaborator

Hey,

we've investigated and surveyed our current customer base, and there isn't genuine interest in WebDAV. Given that we need to maintain the code for a very long time, given support and SLAs, we don't consider adding it to the project.

So I'll close this PR, so you don't wait any longer on a decision that might never happen. Nevertheless thanks a lot for the contribution.

@ImTheKai ImTheKai closed this Sep 18, 2023
@dalbani
Copy link
Contributor Author

dalbani commented Sep 18, 2023

Thanks for your feedback.
In the end, I've come to the conclusion that logical backups are not suited to my use case.
Due to the size of my database, the generated backup files were like 200+ GB (!), even with the best compression.
So I need to have a look at physical backups, is my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants