Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBM-1142] Use UBI-based image for Go builder #853

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[PBM-1142] Use UBI-based image for Go builder #853

merged 1 commit into from
Jul 11, 2023

Conversation

dalbani
Copy link
Contributor

@dalbani dalbani commented Jul 9, 2023

@dalbani dalbani requested a review from defbin as a code owner July 9, 2023 14:32
defbin
defbin previously approved these changes Jul 9, 2023
View reviewed changes
@defbin defbin requested a review from EvgeniyPatlan July 9, 2023 14:37
@dalbani
Copy link
Contributor Author

dalbani commented Jul 9, 2023

Comparing my changes with #840, I'm wondering what this does:

percona-backup-mongodb/.github/workflows/ci.yml

Line 38 in 4f020c6

GO_VER: ${{ github.event.inputs.go_ver || 'bullseye' }}

Shouldn't it contain the Go version itself, as in 1.19, I mean?

@defbin
Copy link
Member

defbin commented Jul 9, 2023

Comparing my changes with #840, I'm wondering what this does:

percona-backup-mongodb/.github/workflows/ci.yml

Line 38 in 4f020c6

GO_VER: ${{ github.event.inputs.go_ver || 'bullseye' }}

Shouldn't it contain the Go version itself, as in 1.19, I mean?

Best to ask @olexandr-havryliak . I guess, it is configurable with defaults to "golang:bullseye" (1.20). Used inside job scripts. But can be changed when run manually.
Do not rush to change all base images. Only docker/* are public. All others are for testing purposes and could be easier to use.

@defbin
Copy link
Member

defbin commented Jul 9, 2023

Could you please revert changes to e2e-tests images? your current changes break them

@dalbani
Copy link
Contributor Author

dalbani commented Jul 9, 2023

Could you please revert changes to e2e-tests images? your current changes break them

My bad, I just force pushed to revert it.

@defbin defbin requested review from defbin and vorsel July 10, 2023 10:25
olexandr-havryliak
olexandr-havryliak approved these changes Jul 11, 2023
View reviewed changes
docker/Dockerfile Show resolved Hide resolved
@defbin defbin merged commit 4ed2332 into percona:main Jul 11, 2023
49 checks passed
@dalbani dalbani deleted the PBM-1142 branch July 11, 2023 20:27
minottic pushed a commit to paulscherrerinstitute/percona-backup-mongodb that referenced this pull request Oct 26, 2023
@dalbani @minottic
Use UBI-based image for Go builder (percona#853)
eb351ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defbin defbin defbin approved these changes

@vorsel vorsel vorsel approved these changes

@olexandr-havryliak olexandr-havryliak olexandr-havryliak approved these changes

@EvgeniyPatlan EvgeniyPatlan Awaiting requested review from EvgeniyPatlan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dalbani @defbin @vorsel @olexandr-havryliak