setup golangci-lint and fix the suggestions #585
defbinreviewdog.yml
on: pull_request
runner / go-test
49s
runner / shellcheck
12s
runner / misspell
18s
runner / alex
52s
runner / golangci-lint
1m 35s
runner / gofmt
32s
runner / shfmt
12s
Annotations
10 errors
|
runner / golangci-lint:
pbm/config.go#L39
string `***` has 13 occurrences, make it a constant (goconst)
|
|
runner / golangci-lint:
pbm/oplog/restore.go#L350
string `applyOps` has 3 occurrences, make it a constant (goconst)
|
|
runner / golangci-lint:
pbm/oplog/restore.go#L647
string `createIndexes` has 3 occurrences, make it a constant (goconst)
|
|
runner / golangci-lint:
cli/delete.go#L29
string `YES` has 3 occurrences, make it a constant (goconst)
|
|
runner / golangci-lint:
cli/delete.go#L287
string `, base` has 3 occurrences, make it a constant (goconst)
|
|
runner / golangci-lint:
cli/delete.go#L285
string `, selective` has 5 occurrences, make it a constant (goconst)
|
|
runner / golangci-lint:
e2e-tests/pkg/tests/sharded/test_delete_backup.go#L48
exitAfterDefer: log.Fatalf will exit, and `defer c.pitrOff()` will not run (gocritic)
|
|
runner / golangci-lint:
e2e-tests/pkg/tests/sharded/test_dist_commit.go#L53
exitAfterDefer: log.Fatalf will exit, and `defer cur.Close(ctx)` will not run (gocritic)
|
|
runner / golangci-lint:
e2e-tests/pkg/tests/sharded/test_pitr_basic.go#L74
exitAfterDefer: log.Fatalf will exit, and `defer c.pitrOff()` will not run (gocritic)
|
|
runner / golangci-lint:
e2e-tests/pkg/tests/sharded/test_pitr_basic.go#L145
exitAfterDefer: log.Fatalln will exit, and `defer tk.Stop()` will not run (gocritic)
|