Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update puppeteer #36

Closed
paceaux opened this issue Apr 1, 2024 · 4 comments
Closed

Update puppeteer #36

paceaux opened this issue Apr 1, 2024 · 4 comments
Assignees
@paceaux
Labels
enhancement New feature or request
Milestone
2.3.0

Comments

@paceaux
Copy link
Owner

paceaux commented Apr 1, 2024

when doing a search with -c we get a "puppeteer old headless deprecation warning"

Update puppeteer.

image
@paceaux
Copy link
Owner Author

paceaux commented Apr 1, 2024

WE should probably just update all the packages.

@paceaux paceaux added the enhancement New feature or request label Apr 1, 2024
@paceaux paceaux self-assigned this Apr 1, 2024
@paceaux
Copy link
Owner Author

paceaux commented Apr 1, 2024

Update:

Can't seem to get passed puppeteer 21.3.8.

Something starting in puppeteer 21.4.0 gets me an error:

Jest: Got error running globalSetup - /Users/frtaylor/Repos/npm/selector-finder/test/config/setup.js, reason: Timed out after waiting 30000ms

@paceaux
Copy link
Owner Author

paceaux commented Apr 3, 2024

turns out puppeteer had a problem w/ environment variables. I deleted those, it all works fine.

merged into dev under #38

@paceaux paceaux added this to the 2.3.0 milestone Apr 3, 2024
@paceaux
Copy link
Owner Author

paceaux commented Aug 21, 2024

merged into master under #42

@paceaux paceaux closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paceaux paceaux

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@paceaux