Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving plugin tab into split editor should not create separate group #35

Open
lguenth opened this issue Sep 16, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@lguenth
Copy link

lguenth commented Sep 16, 2024

Hi oxdc!
I just stumbled upon your plugin 5 minutes ago through the OMG Discord server and immediately managed to mess something up which might be circumvented from your side...

When you drag the plugin's own tab from the sidebar into the general editor area and split the editor into two panes/groups, the new tab group is shown as empty. If you then, stupidly, also hide the group, you cannot access the plugin tab anymore until you disable and re-enable the plugin OR go into zen mode. 😅

obsidian-verttabs-bug.webm

The video hopefully explains that better than I can manage in words. Obviously, this is more a user error than a bug but I have some suggestions regarding this problem that I wanted to share. Feel free to ignore.

The main issue to think about is how you handle the plugin's own tab. It doesn't appear in the sidebar groups and therefore is also "invisible" in the list when dropped in the editor. It might make sense not to leave it out. Similarly, I feel like you should add a check to the "hide group" and perhaps also the "zen mode" feature which excludes the plugin's own tab.

Thanks for making this!

@oxdc
Copy link
Owner

oxdc commented Sep 16, 2024

The main issue to think about is how you handle the plugin's own tab.

Yes, this is tricky! I have noticed this problem before making this plugin public. I'm still figuring out the best UX solution. BTW, thank you for reporting this. I'll keep this issue open for anyone who might have accidentally hidden Vertical Tabs.

@oxdc oxdc added the enhancement New feature or request label Sep 16, 2024
oxdc added a commit that referenced this issue Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants