-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Verdaccio plugin for build improvements #220
Comments
I have max-parallelism=2 set for the builds. Here are the stats so far: Verdaccio enabled, max2cpu buildx config:
Verdaccio disabled, max2cpu config
I have yet to do more builds with verdaccio disabled. The plugin did not work out of the box. I had to change tutor version constraint and remove network:host from docker-compose to make it work on Mac. |
Here are my stats for this testing: With Max-parallelism = 2:
With Max-parallelism = 1:
Note: I had to remove network mode: host from the docker-compose configuration for Verdaccio to get it working on MacOS. |
I also had to remove "network_mode:host" from docker-compose and I was also working on MacOS. Testing on my system results in:
My conclusion:
|
Next steps:
|
Are you guys quite sure that you were hitting verdaccio in your tests, and not the remote NPM registry? The fact that Verdaccio is slower when its cache is filled is perplexing... Also, the Verdaccio plugin is definitely not working for me on Linux. I get:
Turns out that host.docker.internal is not supported on Linux: https://stackoverflow.com/questions/48546124/what-is-the-linux-equivalent-of-host-docker-internal EDIT: I think that the proper command to test optimizations with/without Verdaccio is:
|
It did not work out of the box. During the build, the MFE container could not connect to Verdaccio container. Once network:host was removed from docker-compose, the connection established successfully. Verdaccio container logs showed whenever the registry was hit. |
Announced on https://discuss.openedx.org/t/local-npm-registry-for-mfe-builds/13526, Maksim from Raccoon Gang shared a PoC on using Verdaccio as a npm registry. Tutor-mfe build causes npm cache and other issues consistently. The PoC plugin is an attempt to pave to path for having a dedicated registry meant for npm operations that can be expanded to Tutor officially.
In Tutor Users meet on July 29, it was mentioned that Tutor Maintainers will test the plugin out and share their feedback https://openedx.atlassian.net/wiki/spaces/COMM/pages/3583016961/Tutor+Users+Group#2024-07-29. This ticket aims to cover that testing. Once tested, the stats will be shared on the discuss link.
The text was updated successfully, but these errors were encountered: