Fix Map Popups (and focus traps) #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
requested changes
Sep 17, 2024
packages/map-popup/src/index.tsx
Outdated
| @@ -101,7 +101,7 @@ function entityIsStation(entity: Entity): entity is Station { | |||
| /** | |||
| * Renders a map popup for a stop, scooter, or shared bike | |||
| */ | |||
| export function MapPopup({ closePopup = null, configCompanies, entity, getEntityName, setLocation, setViewedStop }: Props): JSX.Element { | |||
| export function MapPopup({ closePopup = () => null, configCompanies, entity, getEntityName, setLocation, setViewedStop }: Props): JSX.Element { | |||
There was a problem hiding this comment.
Suggested change
| export function MapPopup({ closePopup = () => null, configCompanies, entity, getEntityName, setLocation, setViewedStop }: Props): JSX.Element { | |
| export function MapPopup({ closePopup = () => void, configCompanies, entity, getEntityName, setLocation, setViewedStop }: Props): JSX.Element { |
Should this be void instead?
There was a problem hiding this comment.
This isn't a type it's a default!
There was a problem hiding this comment.
Yes but look at the type! It returns void
There was a problem hiding this comment.
We have a noOp function you can import
miles-grant-ibigroup
approved these changes
Sep 18, 2024
josh-willis-arcadis
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IDs that are breaking due to stop codes, passes
closePopuptoMapPopupthroughotp2-tile-layer, prevent crash on nullclosePopup