Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass operator logos to map popup #775

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Sep 12, 2024

Pass the getEntityPrefix function that brings transit operator logos into map-popup by way of the tile overlay.

image

@binh-dam-ibigroup
Copy link
Collaborator

Pass the getEntityPrefix function that brings transit operator logos into map-popup by way of the tile overlay.

image

Could you add a story that illustrates using getEntityPrefix, please?

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one story tweak, and remember to resolve merge conflicts.

packages/map-popup/src/MapPopup.story.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great!

@amy-corson-ibigroup amy-corson-ibigroup merged commit 9187bed into opentripplanner:master Sep 26, 2024
2 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the pass-operator-logos-to-map-popup branch September 26, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants