a11y: Location field dropdown ID #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
requested changes
Jul 11, 2023
| so that assistive technology can associate the list with the button and input controls. */} | ||
| <ItemList | ||
| // Hide the list from screen readers if no enabled options are shown. | ||
| aria-hidden={hasNoEnabledOptions} |
There was a problem hiding this comment.
Something about this aria-hidden/HiddenCss isn't registering, and these containers are still showing up
There was a problem hiding this comment.
Thanks, I thought I covered that during initial dev, but it didn't work after a fresh compile. Fixed in 0657fd8.
amy-corson-ibigroup
approved these changes
Jul 12, 2023
miles-grant-ibigroup
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the dropdown and its ID continuously visible in the DOM and from the DOM elements that control the dropdown.