Add fare product types to types package #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Removes support for older OTP1/REST legs
miles-grant-ibigroup
approved these changes
Jul 3, 2023
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
|
don't know how to fix this CI issue... it's failing because the types break stuff in other packages. but if I merge them in the same PR we can't update the version number and so they still fail. |
|
I think the solution is to merge it all, get the ci to pass, merge into alpha, do an alpha release, use those versions here, and then it releases. then a subsequent pr updates the version numbers away from alpha |
miles-grant-ibigroup
added
the
BLOCKERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new fare product types to the types package. It breaks compatibility with older versions of OTP and REST API.