Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mode selector enhancements #609

Conversation

daniel-heppner-ibigroup
Copy link
Contributor

This PR does two things:

  • Disables the hover element if there are no sub settings to be displayed.
  • Uses flexbox to fix weird wrapping that was happening on long mode settings

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working, just a few questions

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@daniel-heppner-ibigroup daniel-heppner-ibigroup merged commit 6d0534d into opentripplanner:master Jul 3, 2023
2 checks passed
@daniel-heppner-ibigroup daniel-heppner-ibigroup deleted the mode-selector-enhancements branch July 3, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants