Sync itinerary sort with depart arrive #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| [onSortChange] | ||
| ) | ||
|
|
There was a problem hiding this comment.
this useCallback is probably hurting performance more than anything. onSortChange won't be recreated on renders anyway since it's being passed in
miles-grant-ibigroup
requested changes
Sep 12, 2024
| }, | ||
| [onSortChange] | ||
| ) | ||
|
|
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
|
Thank you! That map was a really good suggestion! |
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
approved these changes
Sep 18, 2024
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
binh-dam-ibigroup
approved these changes
Sep 24, 2024
|
|
||
| import { AppConfig } from '../../util/config-types' | ||
| import { AppReduxState, FilterType, SortType } from '../../util/state-types' | ||
| import { setQueryParam } from '../../actions/form' |
There was a problem hiding this comment.
Write import * as formActions from ... and adjust in mapDispatchToProps accordingly, so that the name of the function is not ambiguous inside the component (2 instances).
There was a problem hiding this comment.
What's the other instance?
There was a problem hiding this comment.
What's the other instance?
Actions imported from narrative.
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
…tp-react-redux into sync-sort-departarrive
|
hadn't realized you had approved, binh. merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This syncs the depart arrive setting from the date time selector with the sort option for the itineraries.
It also adds an associated configuration option.