You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this case it seems I cannot train a new network because Stat_had() will fail.
As mentioned in Error when creating a DenoiCompNet #39 some imports in spas/learning/model_Had_DCAN.py do not work, I have noticed 3 factors that may contribute to this: circular imports, imports using * (star imports) and relative and absolute imports being used in a same file.
In a same file, imports like from ..misc.pattern_choice import Hadamard, matrix2conv (which is a relative import) and from spyrit.misc.statistics import * (which is not) are used, which I believe is not a best practice.
I believe it would be a good idea to review most of the imports in all relevant files, choose to use a method, i.e. relative imports, avoid star imports as much as possible and remove unnecessary legacy imports in file headers.
The text was updated successfully, but these errors were encountered:
I am getting some errors due to import issues.
In spas/misc/statistics.py the following line is used
import spyrit.misc.walsh_hadamard as wh
but then some function calls do not start bywh
as in:spyrit/spyrit/misc/statistics.py
Line 183 in 8c80206
spyrit/spyrit/misc/statistics.py
Line 123 in 8c80206
Stat_had()
will fail.As mentioned in Error when creating a DenoiCompNet #39 some imports in spas/learning/model_Had_DCAN.py do not work, I have noticed 3 factors that may contribute to this: circular imports, imports using
*
(star imports) and relative and absolute imports being used in a same file.In a same file, imports like
from ..misc.pattern_choice import Hadamard, matrix2conv
(which is a relative import) andfrom spyrit.misc.statistics import *
(which is not) are used, which I believe is not a best practice.I believe it would be a good idea to review most of the imports in all relevant files, choose to use a method, i.e. relative imports, avoid star imports as much as possible and remove unnecessary legacy imports in file headers.
The text was updated successfully, but these errors were encountered: