Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denoising layer of DC Net #219

Open
nducros opened this issue Jul 3, 2024 · 3 comments
Open

Denoising layer of DC Net #219

nducros opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@nducros
Copy link
Member

nducros commented Jul 3, 2024

https://spyrit.readthedocs.io/en/master/_autosummary/spyrit.core.recon.Denoise_layer.html#spyrit.core.recon.Denoise_layer

  • Equation does not display well
  • Notations not consistent (\sigma vs. A=)
@nducros nducros added the documentation Improvements or additions to documentation label Jul 3, 2024
@romainphan
Copy link
Contributor

corrected

6628dee

@nducros nducros reopened this Jul 4, 2024
@nducros
Copy link
Member Author

nducros commented Jul 4, 2024

The doc is confusing as the denoise layer only computes the filter (a / a + b), which is designed to be multiplied to some input measurement vector. The usage of the filter is only visible here:

y1 = torch.mul(self.denoi(var), x)

The design of the class seems awkward, as the forward function should actually compute what the doc says, i.e., (a / a + b) input

@nducros nducros mentioned this issue Jul 4, 2024
@romainphan
Copy link
Contributor

#228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants