Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ai-assistant link & add home button & add a qrcode #68

Merged
merged 13 commits into from
Mar 6, 2024
Merged

feat: add ai-assistant link & add home button & add a qrcode #68

merged 13 commits into from
Mar 6, 2024

Conversation

xiaowangxiaowang256256
Copy link
Contributor

@xiaowangxiaowang256256 xiaowangxiaowang256256 commented Mar 5, 2024

本次功能新增说明:
1、在网站全局添加了 AI小助手图标,及link入口 #62
2、所使用的图片,署名了出处及协议内容
3、当产生视觉遮挡时,可点击close按钮,缩小图标显示
4、功能:网站左上角 新增home按钮 #69
5、功能:添加微信公众号二维码 #30

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opensource-f2f-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 9:06am

@xiaowangxiaowang256256 xiaowangxiaowang256256 changed the title feat: add ai-assistant link feat: add ai-assistant link & add home button Mar 5, 2024
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为本功能引入 element-plus 似乎有些没必要,考虑到它会增加 bundle size
因为我们有了 unpluin-icons,所以没有必要使用 @element-plus/icons-vue
我们可以考虑把版权声明页面底部

LinuxSuRen
LinuxSuRen previously approved these changes Mar 6, 2024
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a user perspective.

@xiaowangxiaowang256256
Copy link
Contributor Author

为本功能引入 element-plus 似乎有些没必要,考虑到它会增加 bundle size 因为我们有了 unpluin-icons,所以没有必要使用 @element-plus/icons-vue 我们可以考虑把版权声明页面底部
这是一个很专业的建议。我的代码已调整,请审查。

@xiaowangxiaowang256256 xiaowangxiaowang256256 changed the title feat: add ai-assistant link & add home button feat: add ai-assistant link & add home button & add a qrcode Mar 6, 2024
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked some design details of AI assistant

  • Moved to the right-bottom corner.
  • Memorize the state of if show AI assistant

@sxzz sxzz changed the title feat: add ai-assistant link & add home button & add a qrcode feat: add ai-assistant link & add home button & add a qrcode Mar 6, 2024
@sxzz sxzz merged commit 8d84d6b into opensource-f2f:main Mar 6, 2024
2 checks passed
@xiaowangxiaowang256256
Copy link
Contributor Author

Tweaked some design details of AI assistant

  • Moved to the right-bottom corner.
  • Memorize the state of if show AI assistant

This looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

网站左上角 新增 home跳转按钮 添加 AI 小助手的链接
3 participants