Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: netease music logo #66

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix: netease music logo #66

merged 3 commits into from
Mar 4, 2024

Conversation

xiaowangxiaowang256256
Copy link
Contributor

@xiaowangxiaowang256256 xiaowangxiaowang256256 commented Mar 4, 2024

修复前:
1、无法引用网易云logo,svg图片无法显示
image
2、svg 文字描述为白色,白天模式下 无法阅读
image

修复后:
1、直接引用本地 svg图片
2、svg 文字描述颜色调整为黑色
image

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opensource-f2f-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:08am

LinuxSuRen
LinuxSuRen previously approved these changes Mar 4, 2024
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. See also
image

Thanks for your time.

@LinuxSuRen LinuxSuRen linked an issue Mar 4, 2024 that may be closed by this pull request
@xiaowangxiaowang256256
Copy link
Contributor Author

@LinuxSuRen 你好,要将该pr合并成功,是否需要重新 发起提交申请,并选择两个审批人?
image

@LinuxSuRen
Copy link
Member

@xiaowangxiaowang256256 不用指定,等等其他人就好了,如果一周内没有人响应的话,我可以手动合并。

@xiaowangxiaowang256256
Copy link
Contributor Author

@xiaowangxiaowang256256 不用指定,等等其他人就好了,如果一周内没有人响应的话,我可以手动合并。

好的,谢谢指导

sxzz
sxzz previously approved these changes Mar 4, 2024
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed label since it doesn't support dark mode.

@sxzz sxzz changed the title feat: fix NetEase Music svg fix: netease music logo Mar 4, 2024
@sxzz sxzz enabled auto-merge (squash) March 4, 2024 04:08
@sxzz sxzz disabled auto-merge March 4, 2024 04:08
@sxzz sxzz merged commit 6448643 into opensource-f2f:main Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

网易云音乐 svg 显示有问题
3 participants