Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose removal of bespoke in line crs #59

Closed
marqh opened this issue Mar 30, 2022 · 8 comments · Fixed by #63
Closed

propose removal of bespoke in line crs #59

marqh opened this issue Mar 30, 2022 · 8 comments · Fixed by #63
Labels
V1.0.0 Non-breaking change needed for initial Community Standard

Comments

@marqh
Copy link
Member

marqh commented Mar 30, 2022

https://github.com/opengeospatial/CoverageJSON/blob/master/standard_template/standard/clause_specification_text.adoc#514-providing-inline-definitions-of-crss

the bespoke in line definition is likely to alter significantly as #26 and similar angles are pursued

given the liklihood of these options for 1.1, having this bespoke syntax in 1.0 seems to be storing up problems for backwards compatability

i propose removng this section from the 1.0 version

(this is a long standing discussion: covjson/specification#89)

the external link to a published CRS seems sufficient for v1.0

@jonblower
Copy link
Contributor

I'm also in favour of removing (or at least deprecating) this for 1.0. I'm not aware of anyone that's using the bespoke syntax anyway and it's not well defined.

@jonblower
Copy link
Contributor

I guess there may be an issue if there is not an externally-published CRS that matches the data provider's intent. We should probably have a recommendation for this, even if it's "do what you like, but don't expect interoperability if you use a non-standard format".

As a worst-case fallback, people might want to just provide some information that can't be easily parsed by computers but could at least help a reader:

{
  "type": "VerticalCRS",
  "description": "Height in metres above moving deck of the RSS Research Ship"
}

(The above example is chosen because I'm not sure there is a defined CRS for that kind of thing)

@jonblower jonblower added the V1.0.0 Non-breaking change needed for initial Community Standard label Mar 30, 2022
@jonblower
Copy link
Contributor

Spoke to Maik offline. We're both happy to remove this part of the text - it was never intended to be normative anyway. We could either:

  1. Keep it and clearly mark it "non-normative" to show that it's not part of the spec, or
  2. Replace it with a section saying something like "If there is no previously-defined CRS, then the data provider MAY insert CRS information in another format (e.g. WKT-JSON), in which case the data provider SHOULD provide a human-readable description field to describe their intent. In this case any interoperability with other tools cannot be ensured.", or
  3. Remove it altogether and just leave it outside the scope of the spec

Any thoughts @marqh ?

@marqh
Copy link
Member Author

marqh commented Apr 5, 2022

hi @jonblower

i think that i would prefer option 3 and to remove this altogether, and have it out of scope for 1.0

i think that having non-normative setctions with unstandardised contents is risky and encourages use that we will change in the future

@marqh
Copy link
Member Author

marqh commented Apr 5, 2022

i agree that providing a description field for the CRS is useful

people can always add contextual descriptions for humans

in the scenario where no CRS URI can be used, a text description only is better than nothing

@jonblower
Copy link
Contributor

in the scenario where no CRS URI can be used, a text description only is better than nothing

So does that mean you'd support option 2?

I see this as analogous to what GeoJSON does: GeoJSON only supports CRS84, but has some text that says "use other CRSs if you want, but that's outside the spec and would be application-specific".

@jonblower
Copy link
Contributor

Their wording is, "where all involved parties have a prior arrangement, alternative coordinate reference systems can be used without risk of data being misinterpreted."

@marqh
Copy link
Member Author

marqh commented Apr 5, 2022

i think that we should ensure that the 'id' remains used for the identifier of the CRS
the current text is clear on this

i think adding a description attribute is useful

i'm wary of adding an attribute name to store anything else, or giving options for the id to be used to encode non-standard encodings

description is already free text in other uses, and can be co-opted for non-standardised exchange

So, i prefer removing the section on in-line definitions all together and adding the optional description field to the other sections defining use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1.0.0 Non-breaking change needed for initial Community Standard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants