Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuple delete should support CSV files #256

Open
aaguiarz opened this issue Feb 14, 2024 · 6 comments
Open

tuple delete should support CSV files #256

aaguiarz opened this issue Feb 14, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aaguiarz
Copy link
Member

Given tuple write supports CSV file, we should add support for CSVs in tuple delete for consistency reasons.

We'd be able to run the command below if we want to delete the tuples we just added

fga tuple write --file tuples.csv
fga tuple delete --file tuples.csv
@aaguiarz aaguiarz added the good first issue Good for newcomers label Feb 14, 2024
@rhamzeh rhamzeh added the enhancement New feature or request label Feb 14, 2024
@kindlyturnips
Copy link

kindlyturnips commented Feb 14, 2024

I can attempt this, it will be my first issue / enhancement ever. It may take me some time, hopefully that's alright.

@aaguiarz
Copy link
Member Author

@kindlyturnips sounds great, I'll assign it to you. Thanks a lot!

@kindlyturnips
Copy link

kindlyturnips commented Feb 14, 2024

Hi @aaguiarz, I have an update of what I have accomplished today. It's mostly getting all the dependencies and the project up and running.

Accomplishments

  1. Downloaded and launched the openfga server with docker
  2. Created stores & authorization models for the stores
  3. Successfully written a json
    ./dist/fga tuple write --store-id=<> --file ./cmd/tuple/testdata/tuples.json
  4. Successfully written a csv
    ./dist/fga tuple write --store-id=<> --file ./cmd/tuple/testdata/tuples_without_optional_fields.csv

Tomorrow I will start working on the fga tuple delete --file tuples.csv . Thanks for your patience and allowing me to participate.

@kindlyturnips
Copy link

Hello @aaguiarz I think I have it solved. I'm having difficulty with my git push, It appears that I don't have the authority to do so. Could you check this out for me?

@aaguiarz
Copy link
Member Author

@kindlyturnips
Copy link

Hello @aaguiarz
Thank you for your patience, I've submitted the pull request. Let me know if I made a mistake somewhere in the process.
Thanks again for letting me contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: In progress
Development

No branches or pull requests

3 participants