Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Footer not stay at the bottom #417

Closed
2 tasks done
NsdHSO opened this issue Nov 30, 2022 · 14 comments · Fixed by #474
Closed
2 tasks done

Bug: Footer not stay at the bottom #417

NsdHSO opened this issue Nov 30, 2022 · 14 comments · Fixed by #474
Labels
🐛 bug Something isn't working good first issue Good for newcomers

Comments

@NsdHSO
Copy link
Contributor

NsdHSO commented Nov 30, 2022

Describe the bug

Screenshot 2022-11-30 at 10 18 07

Steps to reproduce

  1. Open in the hot app

Affected services

hot.opensauced.pizza

Platforms

Desktop

Browsers

Chrome

Environment

Production

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@NsdHSO NsdHSO added the 🐛 bug Something isn't working label Nov 30, 2022
@0-vortex 0-vortex added the good first issue Good for newcomers label Nov 30, 2022
@0-vortex
Copy link
Contributor

Good exercise in sticky footers: https://css-tricks.com/couple-takes-sticky-footer/

@me-manikanta
Copy link

I can .take this issue 😁

@a0m0rajab
Copy link

Seems like the issue has been solved, I could not reproduce it.

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Jan 2, 2023

Can you please provide your steps? Because I opened in hot, and reproduced this issue

@a0m0rajab
Copy link

a0m0rajab commented Jan 6, 2023

I opened it from the browser directly: https://hot.opensauced.pizza/

@ganeshrevadi
Copy link

Still an issue?

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Jul 8, 2023

Yes, the footer still has this issue.

@ganeshrevadi
Copy link

Okay ! Here's what I understood from the issue and web page .
The footer needs to persist even if the page is scrolled. Am I right ?
and any suggestions?

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Jul 10, 2023

Yes, this is what we need.

@VinceCYLiao
Copy link

@NsdHSO Is the footer in the video acting as you want ? If yes, please let me know and I'll create a pull request. Thanks!
https://github.com/open-sauced/hot/assets/46563912/c01f210a-b97c-433c-bbbe-a194ddbf16f6

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Jul 10, 2023

@VinceCYLiao sorry I can't open this video

@VinceCYLiao
Copy link

@NsdHSO Sorry I should convert the video into gif. Please check, thanks.
footer

@westernal
Copy link
Contributor

westernal commented Jul 10, 2023

@NsdHSO Correct me if I'm wrong but I think its because the list of repositories renders after few seconds (waiting for server's data) and there is no loading component to render in the time the component is fetching the data from server so I added the loader and made a PR if it helps.

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Jul 10, 2023

@westernal Yes, this is what we want, Tnx for your PR, but can you please check this little doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants