Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break repo into individual designs #14

Open
jonnew opened this issue Sep 24, 2024 · 3 comments
Open

Break repo into individual designs #14

jonnew opened this issue Sep 24, 2024 · 3 comments
Assignees
Milestone

Comments

@jonnew
Copy link
Member

jonnew commented Sep 24, 2024

The repo, as of writing this issue, needs to be divided into 4 repos. The first is the control board and firmware

  1. commutator-controller
    • Control board schematic, PCB, assembly materials
    • Firmware

The additional three are complete designs with (1) included as submodule:

  1. commutator-spi
  2. commutator-coax
  3. commutator-coax-dual
@jonnew jonnew added this to the Revision D milestone Sep 24, 2024
@cjsha
Copy link
Member

cjsha commented Sep 24, 2024

Sure. We decided this will be the last step in Revision D milestone. Two questions:

Depending on which fiber-coax rotary joint we go with, I suggest calling it "commutator-dual" instead of "commutator-coax-dual" if it accommodates both the fiber-coax rotary joint and coax-coax rotary joint.

@cjsha
Copy link
Member

cjsha commented Sep 30, 2024

https://github.com/open-ephys/commutator-dual
https://github.com/open-ephys/commutator-spi
https://github.com/open-ephys/commutator-coax
https://github.com/open-ephys/commutator-controller

They are still private github repos - I just wanna double-check that the licensing, READMEs, how organized teensy designs vs rp2040 designs (i.e. rev c & before vs rev d & after), etc. are ok.

@jonnew
Copy link
Member Author

jonnew commented Sep 30, 2024

Looks good. I can review when I get in, then we can deprecate this one and make public.

We need to update the docs links too, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants