Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set storage size limit for quota when using Ansible variables #709

Closed
hambuergaer opened this issue Jul 3, 2023 · 2 comments · Fixed by #712
Closed

Can't set storage size limit for quota when using Ansible variables #709

hambuergaer opened this issue Jul 3, 2023 · 2 comments · Fixed by #712

Comments

@hambuergaer
Copy link

SUMMARY:

The current implementation of this module seems not to be able to set storage size limit quota while using Ansible variables like e.g. "{{ storage_size }}"

It seems that "limit=storage.get('size')" must be "limit=int(storage.get('size'))" instead.

https://github.com/oVirt/ovirt-ansible-collection/blob/9befbcf12fd942a961daca9ab3aaa178a59cd76d/plugins/modules/ovirt_quota.py#L312C31-L312C50

hambuergaer pushed a commit to hambuergaer/ovirt-ansible-collection that referenced this issue Jul 3, 2023
@mnecas
Copy link
Member

mnecas commented Jul 19, 2023

Hi! I apologize for the late reply.
Thanks for the issue and the PR! I tried to update your original PR but once I pushed it to your branch it for some reason closed the PR. So I created a new one.

@hambuergaer
Copy link
Author

Hi @mnecas, no worries! Thank you for keeping an eye on that. Can you already estimate when this change will be released in the next version? It seems that Ansible lint still finds some errors: https://github.com/oVirt/ovirt-ansible-collection/actions/runs/5595712007/job/15156737978?pr=712

Best regards

Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants