Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets support #5

Closed
bondehagen opened this issue Oct 19, 2023 · 9 comments · Fixed by #212
Closed

WebSockets support #5

bondehagen opened this issue Oct 19, 2023 · 9 comments · Fixed by #212
Labels

Comments

@bondehagen
Copy link
Contributor

I'm currently using websockets in solid-start (although it needed some modifications to the source). Will there be a way to upgrade http connections to websockets in Vinxi?
It does not seem to be support for this in Nitro unjs/nitro#678

@nksaraf
Copy link
Owner

nksaraf commented Oct 23, 2023

I am working with the nitro team on this. We already enabled websocket support for the dev server using @vinxi/listhen, a temporary fork of listhen that enables websocket support until unjs/listhen#128 lands.

We will then try to land APIs for h3 and nitro that make it easy to write cross-platform websocket servers

@shiro
Copy link

shiro commented Jan 29, 2024

Now that the referenced PR is closed, is there any place to track the progress on WS support, h3/nitro API, etc.?

@nksaraf
Copy link
Owner

nksaraf commented Jan 30, 2024

So looks like unjs has introduced crossws package. This will be integrated in h3/nitro soon. I don't think there is a tracking issue, but we should get this soon. @pi0 i don't know if we have a timeline yet right

@bondehagen
Copy link
Contributor Author

I guess the important part that is missing, is the hook to listen for the upgrade event unjs/nitro#2041
Hopefully @pi0 will take a look at it soon.

@nksaraf
Copy link
Owner

nksaraf commented Feb 29, 2024

released in 0.3.6

@shiro
Copy link

shiro commented Mar 1, 2024

Thanks a lot! Is there a tracking issue for bringing this into start?

@nksaraf
Copy link
Owner

nksaraf commented Mar 2, 2024

Its immediately available in start. Set server.experimental.websocket: true in config file.

You can then add a new router to your vinxi app, like this:

import { defineConfig } from "@solidjs/start/config";

const app = defineConfig({
  server: {
    experimental: {
      websocket: true,
    },
  },
});

app.addRouter({
  name: "websocket",
  type: "http",
  handler: "./src/websocket.ts",
  target: "server",
  base: "/_ws",
});

export default app;

src/websocket.ts

import { defineWebSocket, eventHandler } from "vinxi/http";

export default eventHandler({
	handler: () => {},
	websocket: defineWebSocket({
		async open(event) {
			console.log("WebSocket opened");
		},
		async message(peer, event) {
			console.log("WebSocket message", event);
			peer.send("YOOO");
		},
		async close(event) {
			console.log("WebSocket closed 3");
		},
	}),
});

To connect to the websocket try,

const ws = new WebSocket('ws://localhost:3000/_ws')

@frenzzy
Copy link

frenzzy commented Mar 12, 2024

Is there a way to import WSRequest, Peer, Message etc. types from vinxi?

defineWebSocket({
  upgrade: (req: WSRequest) => MaybePromise<void | { headers?: HeadersInit }>;
  message: (peer: Peer, message: Message) => MaybePromise<void>;
  open: (peer: Peer) => MaybePromise<void>;
  close: (peer: Peer, details: { code?: number; reason?: string }) => MaybePromise<void>;
  error: (peer: Peer, error: WSError) => MaybePromise<void>;
})

@frenzzy
Copy link

frenzzy commented Mar 12, 2024

Thanks a lot! Is there a tracking issue for bringing this into start?

Maybe it should look something like this: solidjs/solid-start#1384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants