Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health check to make sure emails are not used twice #17146

Open
georgehrke opened this issue Sep 15, 2019 · 5 comments
Open

Add health check to make sure emails are not used twice #17146

georgehrke opened this issue Sep 15, 2019 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caldav Related to CalDAV internals feature: users and groups

Comments

@georgehrke
Copy link
Member

We should add a health check to make sure emails are not used by multiple users, since that massively !@#$s up calendar scheduling.

Most user backends store that information in oc_preferences. (appid = settings, configkey = email).

We should do a simple database request and make sure emails are unique in there.

@georgehrke georgehrke added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 15, 2019
@georgehrke georgehrke self-assigned this Sep 15, 2019
@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 15, 2019
@georgehrke georgehrke added this to the Nextcloud 18 milestone Sep 15, 2019
@Nils160988
Copy link
Contributor

I have a few use cases / installations where it is common to have multiple users with the same email:

Usually, there is one administrative account which holds certain shares/calendar for everyone. This account should be independent from regular user accounts. If one person has both a regular user account and takes care of the administrative account, the two accounts will have the same email.

Is this considered bad practice (why?) or can you suggest an alternative setup when you will no longer support same email for multiple accounts?

The other use case would be test instances where I like to create a few test users with the same email (this case is not so important).

@georgehrke
Copy link
Member Author

Is this considered bad practice (why?) or can you suggest an alternative setup when you will no longer support same email for multiple accounts?

We will not prohibit it. We will just show a warning that's it is not supported when using caldav scheduling.

@Nils160988
Copy link
Contributor

For the test instances, ok, no problem then.

But if I would like to use caldav scheduling as well for my first use case (administrative account and regular account with the same mail address)? Do I have any other options apart from creating an additional mail address?

@georgehrke
Copy link
Member Author

Do I have any other options apart from creating an additional mail address?

No. Scheduling is not supported when email addresses are not unique.

@Nils160988
Copy link
Contributor

OK, thanks for the information.

It should be noted in the user management part of the documentation that non-unique mail addresses are not (fully) supported. Also it might help if the warning already shows up when trying to create a second user with the same mail address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caldav Related to CalDAV internals feature: users and groups
Projects
None yet
Development

No branches or pull requests

4 participants