fix: EXT-SERVICE otel golden error rate fix (#402)

newrelic · Jan 20, 2022 · 459ce6e · 459ce6e
1 parent 2a75a1f
commit 459ce6e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/definitions/ext-service/golden_metrics.yml b/definitions/ext-service/golden_metrics.yml
@@ -18,8 +18,9 @@ errorRate:
   title: Error rate (%)
   queries:
     opentelemetry:
-      select: (filter(count(*), where error.message IS NOT NULL) * 100) / count(*)
+      select: (filter(count(*), WHERE otel.status_code = 'ERROR') * 100) / count(*)
       from: Span
+      where: span.kind IN ('server', 'consumer') OR kind IN ('server', 'consumer')
     kamon-agent:
       select: (filter(sum(http.server.requests), where http.status_code = '5xx') * 100) / sum(http.server.requests)
       from: Metric

diff --git a/definitions/ext-service/summary_metrics.yml b/definitions/ext-service/summary_metrics.yml
@@ -50,8 +50,8 @@ errorRate:
   unit: PERCENTAGE
   queries:
     opentelemetry:
-      select: filter(count(*), where error.message IS NOT NULL) / count(*) * 100
-      from: Span
+      select: average(newrelic.goldenmetrics.ext.service.errorRate)
+      from: Metric
       eventId: entity.guid
     kamon-agent:
       select: filter(sum(http.server.requests), where http.status_code = '5xx') / sum(http.server.requests) * 100