Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row height does not scale with font #212

Open
ldionmarcil opened this issue Jun 19, 2024 · 1 comment
Open

Row height does not scale with font #212

ldionmarcil opened this issue Jun 19, 2024 · 1 comment
Labels

Comments

@ldionmarcil
Copy link
Contributor

Description:
On a fresh Burp install on Linux, the height of rows is much too small relative to the font size, making it unreadable. Might be a regression from #2

Steps To Reproduce:
Open logger++ and browse a little.

Expected behavior:
The rows are adapted to the height of the font size.

Screenshots:
image

Version:
3.20.1, downloaded from Github

@ldionmarcil
Copy link
Contributor Author

I think it has something to do with my DPI settings, although I disabled it in Burp. As a workaround for now, I simply increased the size of each rows to 45.

diff --git a/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java b/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java
index 98048a6..bd68f50 100644
--- a/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java
+++ b/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java
@@ -44,7 +44,7 @@ public class LogTable extends JTable
 
         this.setTableHeader(controller.getTableHeader()); // This was used to create tool tips
         this.setAutoResizeMode(JTable.AUTO_RESIZE_OFF); // to have horizontal scroll bar
-        this.setRowHeight(20); // As we are not using Burp customised UI, we have to define the row height to make it more pretty
+        this.setRowHeight(45); // As we are not using Burp customised UI, we have to define the row height to make it more pretty
         this.setDefaultRenderer(Boolean.class, new BooleanRenderer()); //Fix grey checkbox background
         ((JComponent) this.getDefaultRenderer(Boolean.class)).setOpaque(true); // to remove the white background of the checkboxes!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant