From e6c49fed513878f678110a923b071f266d4a2af6 Mon Sep 17 00:00:00 2001 From: rupansh Date: Wed, 7 Jun 2023 16:32:33 +0530 Subject: [PATCH 1/2] chore(sdk/core): bump bip39 to v2.0.0 --- sdk/core/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/core/Cargo.toml b/sdk/core/Cargo.toml index 8305377624..83629d90af 100644 --- a/sdk/core/Cargo.toml +++ b/sdk/core/Cargo.toml @@ -23,7 +23,7 @@ serde_json = { version = "1.0.68", features = ["preserve_order"] } serde_repr = "0.1.8" anyhow = "1.0.44" rand = "0.6.0" -bip39 = "1.0.1" +bip39 = { version = "2.0.0", features = ["rand"] } sha2 = "0.9.8" sha3 = "0.9.1" hmac = { version = "0.11.0", features = ["std"] } From f4692b4f28735812a67ae77877d7596f37b19e18 Mon Sep 17 00:00:00 2001 From: rupansh Date: Wed, 7 Jun 2023 17:29:28 +0530 Subject: [PATCH 2/2] chore(sdk/core): bump rand to v0.8.5 --- sdk/core/Cargo.toml | 2 +- sdk/core/src/wallet.rs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/sdk/core/Cargo.toml b/sdk/core/Cargo.toml index 83629d90af..723eb98205 100644 --- a/sdk/core/Cargo.toml +++ b/sdk/core/Cargo.toml @@ -22,7 +22,7 @@ serde = { version = "1.0.130", features = ["derive"] } serde_json = { version = "1.0.68", features = ["preserve_order"] } serde_repr = "0.1.8" anyhow = "1.0.44" -rand = "0.6.0" +rand = "0.8.5" bip39 = { version = "2.0.0", features = ["rand"] } sha2 = "0.9.8" sha3 = "0.9.1" diff --git a/sdk/core/src/wallet.rs b/sdk/core/src/wallet.rs index ff96953e79..159a1e6098 100644 --- a/sdk/core/src/wallet.rs +++ b/sdk/core/src/wallet.rs @@ -30,8 +30,7 @@ pub struct Wallet { impl Wallet { // GenerateMnemonic will generate a new mnemonic value using the bip39 implementation pub fn generate_mnemonic() -> Mnemonic { - let mut rng = rand::thread_rng(); - Mnemonic::generate_in_with(&mut rng, Language::English, 24).unwrap() + Mnemonic::generate_in(Language::English, 24).unwrap() } fn seed_from_mnemonic(mnemonic: Mnemonic, password: &str) -> [u8; 64] {