Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scraping game manuals from screenscraper.fr #343

Open
jmt-gh opened this issue May 23, 2022 · 5 comments
Open

Add support for scraping game manuals from screenscraper.fr #343

jmt-gh opened this issue May 23, 2022 · 5 comments

Comments

@jmt-gh
Copy link

jmt-gh commented May 23, 2022

Describe the feature / request
Screenscraper.fr hosts game manuals in addition to all of the other media it hosts. It would be great to be able to scrape this.

Additional context
Use case: Some retro games can be really esoteric! Having the manuals available would be great. I use Skyscraper to do all of my meta data scraping, so being able to leverage my existing workflow would be great instead of having to find a new one.

The response from the URL that gets generated here in screepscraper.cpp already contains the URLs for the game manuals (called manuels). It is available under ['response']['jeu']['medias']. From there, in the individual item, they are identified by type ['manuel'], with the resource itself being available at ['url']. The ones that I have spot checked so far are all .pdf files.

@jmt-gh
Copy link
Author

jmt-gh commented May 24, 2022

I have minimal c++ experience, but I was able to get this up and running by duplicating a lot (basically all) of the functionality that exists for the video download feature. I'll open up a PR with the change soon, though I expect it isn't necessarily up to par.

@MrBullfinsh
Copy link

What is the current status of the PR? I would really appreciate this feature! Thank you for your effort. :-)

@HVR88
Copy link

HVR88 commented Jul 31, 2022

@jmt-gh there is another fork of Skyscraper (linked below) that is accepting pull requests and under current development.

https://github.com/detain/skyscraper

You should post your changes there.

@MrBullfinsh
Copy link

@HVR88 The problem here is not that there is a PR that is not accepted, but that there is no PR and no commit on the fork either. So no publicly available change on this topic.

@HVR88
Copy link

HVR88 commented Aug 2, 2022

@HVR88 The problem here is not that there is a PR that is not accepted, but that there is no PR and no commit on the fork either. So no publicly available change on this topic.

My reply was directed at the issue author in hopes he publishes the PR somewhere/anywhere. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants