Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use propper logging #14

Open
schnecki opened this issue Jul 9, 2018 · 2 comments
Open

Use propper logging #14

schnecki opened this issue Jul 9, 2018 · 2 comments

Comments

@schnecki
Copy link

schnecki commented Jul 9, 2018

It would make sense to use a proper logging mechanism instead of writing to standard output. I am thinking of Control.Monad.Logger or similar.
Otherwise at least add a preprocessor statement for turning on/off debugging:

debugging = 
#ifdef DEBUG
    True       
#else 
    False
#endif 
@mr
Copy link
Owner

mr commented Jul 9, 2018

I'd definitely prefer to add real logging over CPP, but it's a matter of time for me right now. There are tons of things I'd like to improve, but other projects have just been more important to me lately.

I'm thinking about wrapping everything into a reader monad on top of IO that uses the handler as it's environment (or at least the handler will be part of it) and then instancing classes in monad-logger. It'll take some time to research and implement, and you're welcome to give it a shot if you want to send a PR.

@schnecki
Copy link
Author

schnecki commented Jul 9, 2018

Yeah I am quite busy currently myself. Just wanted to list it as a issue, as I did not find it yet. If at some point I have time for it I might give it a try, but unfortunately that can take several months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants