Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting of electron fraction in binned volume #16

Open
momentoscopists opened this issue May 2, 2018 · 3 comments
Open

Reporting of electron fraction in binned volume #16

momentoscopists opened this issue May 2, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@momentoscopists
Copy link
Member

It would be nice if the binner function would return in the end a report of the fraction of electrons in the binned volume (e.g. 15 Mcts out of a total of 20 Mcts in the run binned (75%))

@momentoscopists momentoscopists added the enhancement New feature or request label May 2, 2018
@steinnymir
Copy link
Member

I will add such information to the calcculateBinnedArray function, on which I am working already for the h5 output format.

@steinnymir steinnymir self-assigned this May 7, 2018
@balerion
Copy link
Collaborator

This would require, among other things, to include self.numOfElectrons in the parquet files. I think this would be a really useful upgrade

@steinnymir
Copy link
Member

I agree, and this recalls to the general issue of populating metadata in the process of generating the dataframe. This is partially implemented but need some more work to get it up and running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants