Async APIs not working

[Cyberboss]

Description

VsTestConsoleWrapper.StartSessionAsync() never succeeds.

You're awaiting the handshake task here:

vstest/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleRequestSender.cs

Lines 136 to 139 in e9b28ec

	await Task.Run(() =>
	_communicationManager.AcceptClientAsync(), timeoutSource.Token).ConfigureAwait(false);
	_handShakeSuccessful = await HandShakeWithVsTestConsoleAsync().ConfigureAwait(false);

Before actually starting the console process here:

vstest/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleWrapper.cs

Line 595 in e9b28ec

_vstestConsoleProcessManager.StartProcess(_consoleParameters);

Steps to reproduce

var testConsoleWrapper = new VsTestConsoleWrapper(executable);
await testConsoleWrapper.StartSessionAsync();

Expected behavior

The Task returned by StartSessionAsync() eventually completes.

Actual behavior

The Task returned by StartSessionAsync() eventually never completes.

Diagnostic logs

None

Environment

vstest.console.exe version: 17.0.33007.217
Target .NET version: net472

PS C:\Users\Cyberboss> dotnet --list-sdks
1.1.10 [C:\Program Files\dotnet\sdk]
1.1.14 [C:\Program Files\dotnet\sdk]
2.1.202 [C:\Program Files\dotnet\sdk]
2.1.526 [C:\Program Files\dotnet\sdk]
5.0.202 [C:\Program Files\dotnet\sdk]
5.0.214 [C:\Program Files\dotnet\sdk]
5.0.404 [C:\Program Files\dotnet\sdk]
5.0.408 [C:\Program Files\dotnet\sdk]
6.0.313 [C:\Program Files\dotnet\sdk]
6.0.410 [C:\Program Files\dotnet\sdk]
7.0.100 [C:\Program Files\dotnet\sdk]
7.0.304 [C:\Program Files\dotnet\sdk]

AB#1865062

[nohwnd]

This is a long standing issue with the async api, they don't work, and are not really async in the sense that we understand them now (not blocking threads).

There have been few attempts to fix this (from my side) but it needs the api to be fully redesigned to avoid additional hacks.

[nohwnd]

We are discussing if we should make a breaking change and fix them, or make them obsolete, because in the current form you don't get any additional benefit of using them, they do async over sync.

[nohwnd]

We decided to make them obsolete, because the apis don't work, and were not designed for what is nowadays understood as Async. We would have to redesign and completely rewrite the client to follow async practices, which is not something we can commit to right now.