Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asTime API #239

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix asTime API #239

merged 1 commit into from
Aug 21, 2024

Conversation

goccy
Copy link
Member

@goccy goccy commented Aug 21, 2024

SSIA

Copy link

Code Metrics Report

main (adf6a0e) #239 (d9726f0) +/-
Coverage 65.5% 65.5% +0.0%
Code to Test Ratio 1:0.3 1:0.3 +0.0
Test Execution Time 7m7s 7m4s -3s
Details
  |                     | main (adf6a0e) | #239 (d9726f0) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          65.5% |          65.5% | +0.0% |
  |   Files             |             71 |             71 |     0 |
  |   Lines             |          11990 |          11990 |     0 |
+ |   Covered           |           7849 |           7850 |    +1 |
+ | Code to Test Ratio  |          1:0.3 |          1:0.3 |  +0.0 |
  |   Code              |          37291 |          37291 |     0 |
+ |   Test              |          12984 |          13000 |   +16 |
+ | Test Execution Time |           7m7s |           7m4s |   -3s |

Code coverage of files in pull request scope (68.3% → 68.7%)

Files Coverage +/-
grpc/federation/cel/time.go 68.7% +0.4%

Reported by octocov

@goccy goccy merged commit 5b6a227 into main Aug 21, 2024
4 checks passed
@goccy goccy deleted the fix-as-time branch August 21, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant