Merge pull request #219 from mercari/fix_unimplemented_server

Embed unimplemented server by value instead of pointer
mercari · Aug 6, 2024 · 95e38b6 · 95e38b6
2 parents 98f250e + dcc698b
commit 95e38b6
Show file tree

Hide file tree

Showing 39 changed files with 42 additions and 42 deletions.
diff --git a/_examples/01_minimum/federation/federation_grpc_federation.pb.go b/_examples/01_minimum/federation/federation_grpc_federation.pb.go
diff --git a/_examples/02_simple/federation/federation_grpc_federation.pb.go b/_examples/02_simple/federation/federation_grpc_federation.pb.go
diff --git a/_examples/03_custom_resolver/federation/federation_grpc_federation.pb.go b/_examples/03_custom_resolver/federation/federation_grpc_federation.pb.go
diff --git a/_examples/04_timeout/federation/federation_grpc_federation.pb.go b/_examples/04_timeout/federation/federation_grpc_federation.pb.go
diff --git a/_examples/05_async/federation/federation_grpc_federation.pb.go b/_examples/05_async/federation/federation_grpc_federation.pb.go
diff --git a/_examples/06_alias/federation/federation_grpc_federation.pb.go b/_examples/06_alias/federation/federation_grpc_federation.pb.go
diff --git a/_examples/07_autobind/federation/federation_grpc_federation.pb.go b/_examples/07_autobind/federation/federation_grpc_federation.pb.go
diff --git a/_examples/08_literal/federation/federation_grpc_federation.pb.go b/_examples/08_literal/federation/federation_grpc_federation.pb.go
diff --git a/_examples/09_multi_user/federation/federation_grpc_federation.pb.go b/_examples/09_multi_user/federation/federation_grpc_federation.pb.go
diff --git a/_examples/10_oneof/federation/federation_grpc_federation.pb.go b/_examples/10_oneof/federation/federation_grpc_federation.pb.go
diff --git a/_examples/11_multi_service/federation/federation_grpc_federation.pb.go b/_examples/11_multi_service/federation/federation_grpc_federation.pb.go
diff --git a/_examples/11_multi_service/federation/other_grpc_federation.pb.go b/_examples/11_multi_service/federation/other_grpc_federation.pb.go
diff --git a/_examples/12_validation/federation/federation_grpc_federation.pb.go b/_examples/12_validation/federation/federation_grpc_federation.pb.go
diff --git a/_examples/13_map/federation/federation_grpc_federation.pb.go b/_examples/13_map/federation/federation_grpc_federation.pb.go
diff --git a/_examples/14_condition/federation/federation_grpc_federation.pb.go b/_examples/14_condition/federation/federation_grpc_federation.pb.go
diff --git a/_examples/15_cel_plugin/federation/federation_grpc_federation.pb.go b/_examples/15_cel_plugin/federation/federation_grpc_federation.pb.go
diff --git a/_examples/16_code_gen_plugin/federation/federation_grpc_federation.pb.go b/_examples/16_code_gen_plugin/federation/federation_grpc_federation.pb.go
diff --git a/_examples/17_error_handler/federation/federation_grpc_federation.pb.go b/_examples/17_error_handler/federation/federation_grpc_federation.pb.go
diff --git a/_examples/18_load/federation/federation_grpc_federation.pb.go b/_examples/18_load/federation/federation_grpc_federation.pb.go
diff --git a/_examples/19_retry/federation/federation_grpc_federation.pb.go b/_examples/19_retry/federation/federation_grpc_federation.pb.go
diff --git a/demo/swapi/swapi/swapi_grpc_federation.pb.go b/demo/swapi/swapi/swapi_grpc_federation.pb.go
diff --git a/generator/templates/server.go.tmpl b/generator/templates/server.go.tmpl
@@ -169,7 +169,7 @@ const (
 
 // {{ $serviceName }} represents Federation Service.
 type {{ $serviceName }} struct {
-	*Unimplemented{{ $serviceName }}Server
+	Unimplemented{{ $serviceName }}Server
 	cfg {{ $serviceName }}Config
 	logger *slog.Logger
 	errorHandler grpcfed.ErrorHandler

diff --git a/generator/testdata/expected_alias.go b/generator/testdata/expected_alias.go
diff --git a/generator/testdata/expected_async.go b/generator/testdata/expected_async.go
diff --git a/generator/testdata/expected_autobind.go b/generator/testdata/expected_autobind.go
diff --git a/generator/testdata/expected_condition.go b/generator/testdata/expected_condition.go
diff --git a/generator/testdata/expected_create_post.go b/generator/testdata/expected_create_post.go
diff --git a/generator/testdata/expected_custom_resolver.go b/generator/testdata/expected_custom_resolver.go
diff --git a/generator/testdata/expected_env.go b/generator/testdata/expected_env.go
diff --git a/generator/testdata/expected_error_handler.go b/generator/testdata/expected_error_handler.go
diff --git a/generator/testdata/expected_inline_env.go b/generator/testdata/expected_inline_env.go
diff --git a/generator/testdata/expected_map.go b/generator/testdata/expected_map.go
diff --git a/generator/testdata/expected_minimum.go b/generator/testdata/expected_minimum.go
diff --git a/generator/testdata/expected_multi_user.go b/generator/testdata/expected_multi_user.go
diff --git a/generator/testdata/expected_oneof.go b/generator/testdata/expected_oneof.go
diff --git a/generator/testdata/expected_ref_env.go b/generator/testdata/expected_ref_env.go
diff --git a/generator/testdata/expected_resolver_overlaps.go b/generator/testdata/expected_resolver_overlaps.go
diff --git a/generator/testdata/expected_simple_aggregation.go b/generator/testdata/expected_simple_aggregation.go
diff --git a/generator/testdata/expected_validation.go b/generator/testdata/expected_validation.go