Credential Tagging Implementation #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list We already know what it is... so let's not transmit thousands of the same value over the wire.
This actually works pretty well, but there is no way to add or manage tags through the app yet, and a tag search doesn't yet work in combination with the standard text search (which it should).
This will do until I can restyle the tag input using flexbox/grid...
Dapper doesn't like you passing a list to multi-statement SQL; it seems to just ignore the DELETE completely. So this just splits out the DELETE from the UPDATE.
|
Currently a search returns credentials which match any of the selected tags; should tag searches only return credentials which match all tags? I'm not totally sure which would be more useful. Maybe there should be an app or user setting to control this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credentials should be taggable with one or more tags, which can then be used to narrow down the search.
A nice additional feature (later) would be to optionally persist the selected tags with a cookie (or a URL parameter), so that you could immediately start in the right filtered set on login.
Closes #29.