From f87ab2841b01d123a87acf5c9792be225e65f984 Mon Sep 17 00:00:00 2001
From: Anton Maminov <anton.linux@gmail.com>
Date: Sun, 18 Mar 2018 21:05:40 +0200
Subject: [PATCH] Fix basic auth (#72)

* fix basic auth

* version 0.9.8

* add github sample
---
 samples/github.cr    | 14 ++++++++++++++
 shard.yml            |  2 +-
 src/crest/request.cr |  2 +-
 src/crest/version.cr |  2 +-
 4 files changed, 17 insertions(+), 3 deletions(-)
 create mode 100644 samples/github.cr

diff --git a/samples/github.cr b/samples/github.cr
new file mode 100644
index 00000000..5e07a233
--- /dev/null
+++ b/samples/github.cr
@@ -0,0 +1,14 @@
+require "../crest"
+
+user = ENV["GITHUB_USER"]
+key = ENV["GITHUB_KEY"]
+
+client = Crest::Resource.new(
+  "https://api.github.com",
+  user: user,
+  password: key,
+  logging: true,
+)
+
+response = client["/search/repositories?q=language=Crystal"].get
+puts response.body
diff --git a/shard.yml b/shard.yml
index 2c8aa86d..0b6bb897 100644
--- a/shard.yml
+++ b/shard.yml
@@ -1,5 +1,5 @@
 name: crest
-version: 0.9.7
+version: 0.9.8
 
 authors:
   - Anton Maminov <anton.maminov@gmail.com>
diff --git a/src/crest/request.cr b/src/crest/request.cr
index 617c9d02..16dcde7e 100644
--- a/src/crest/request.cr
+++ b/src/crest/request.cr
@@ -152,7 +152,7 @@ module Crest
     private def basic_auth(user, password)
       return unless user && password
 
-      value = "Basic " + Base64.encode(user + ":" + password).chomp
+      value = "Basic #{Base64.strict_encode("#{user}:#{password}")}"
       @headers.add("Authorization", value)
     end
 
diff --git a/src/crest/version.cr b/src/crest/version.cr
index 0dcb5159..f2bc432c 100644
--- a/src/crest/version.cr
+++ b/src/crest/version.cr
@@ -1,3 +1,3 @@
 module Crest
-  VERSION = "0.9.7"
+  VERSION = "0.9.8"
 end