Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Flat, Round, Chance params in stats #240

Open
1 task done
3Lord3 opened this issue Jun 13, 2024 · 1 comment
Open
1 task done

[Bug]: Flat, Round, Chance params in stats #240

3Lord3 opened this issue Jun 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@3Lord3
Copy link

3Lord3 commented Jun 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I created item generator with 1-2 stats (Durability 100% and Mana_regen 50% (1-10)) with Flat Range and Round. Flat range and/or rounding does not work. Durability appears, but mana_regen appears VERY rarely (Two out of a hundred!) even if I set the chance to 99.9%. If I set at least 2 stats, then mana regen will always be

Expected Behavior

Flat Range and Round work, stat chances work correctly

Steps To Reproduce

  1. Create item generator
  2. Add 1-2 stats (Durability 100% + some stat any%) with Flat Range and Round
  3. Disable other stats
  4. Check generated items

Environment

- Server Software: Purpur 1.20.6-2227-79d199c (MC: 1.20.6)*
- Divinity Version: 1.0.0-R0.17-SNAPSHOT
- Codex Version: 1.0.0-R0.17-SNAPSHOT
- Plugins: Paper Plugins: (3): Codex, Divinity, Fabled | Bukkit Plugins: (1): PlaceholderAPI, ProtocolLib, spark

latest.log

No response

Anything else?

uncommon_staff.txt

@3Lord3 3Lord3 added the bug Something isn't working label Jun 13, 2024
@goflishMC
Copy link
Contributor

goflishMC commented Jun 13, 2024

It's not really a bug, the code was just never finished for defense and item stats.

It only works for Damage Types right now. I have a issue already opened to add it to armor. I'll get it put on the list for item stats, but not sure about ETA, could be a few weeks. We have a lot already that we are working on.

I'll see if I get the same results with mana_regen not showing up very often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants