Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_experiment parameter seems not working (at least in some cases) #29

Open
Alvant opened this issue Feb 26, 2020 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Alvant
Copy link
Collaborator

Alvant commented Feb 26, 2020

import topicnet

dataset = topicnet.cooking_machine.Dataset(...)
model = topicnet.cooking_machine.models.TopicModel(...)

cube = CubeCreator(
    num_iter=10,
    parameters={
        "seed": [11221963],
        "num_topics": [5, 10]
    }
)
exp = Experiment(
    model,
    experiment_id='exp1',
    save_path='should_not_be_created',
    save_experiment=False
)

cube(model, dataset)

Result: folder specified in experiment init should_not_be_created exists
Expected: there shouldn't be any such folder, because save_experiment=False

@Alvant Alvant added the invalid This doesn't seem right label Feb 26, 2020
@Alvant Alvant added bug Something isn't working and removed invalid This doesn't seem right labels Mar 20, 2020
@Evgeny-Egorov-Projects
Copy link
Contributor

Is it closed now?

@Alvant
Copy link
Collaborator Author

Alvant commented Sep 5, 2020

I think it is not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants