Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AWS EC2 network interface module to new data model #1218

Closed
achantavy opened this issue Jul 15, 2023 · 0 comments · Fixed by #1219
Closed

Refactor AWS EC2 network interface module to new data model #1218

achantavy opened this issue Jul 15, 2023 · 0 comments · Fixed by #1219
Labels
AWS Related to cartography's AWS module

Comments

@achantavy
Copy link
Contributor

achantavy commented Jul 15, 2023 •
edited
Loading

Makes #1024 easier.

We'd like to join on an EC2 instance using ARN instead of the instanceid, and many different node types are attached to EC2 instances including network interfaces.
@achantavy achantavy added the AWS Related to cartography's AWS module label Jul 15, 2023
achantavy added a commit that referenced this issue Jul 17, 2023
@achantavy
refactor: #1218, fix: #1152
117d65f
@achantavy achantavy linked a pull request Jul 17, 2023 that will close this issue
fix :#1218, #1152 - refactor EC2 network interface, private ip #1219
Merged
achantavy added a commit that referenced this issue Jul 17, 2023
@achantavy
refactor: #1218, fix: #1152
8d3f83f
achantavy added a commit that referenced this issue Sep 11, 2023
@achantavy
refactor: #1218, fix: #1152
e1866f2
achantavy added a commit that referenced this issue Sep 20, 2023
@achantavy
fix :#1218, #1152 - refactor EC2 network interface, private ip (#1219)
1d81839 
Refactors EC2 Network Interfaces and Private IPs to the cartography data
model. Fixes #1152 since the data model includes automatic cleanup jobs.

- Uses same technique as #1214 to represent Network Interfaces as known
by EC2 instances vs Network Interfaces known by
describe-network-interfaces.
- Also clearly marks that the Private IPs ingested here are known by
Network Interfaces and not another source.
chandanchowdhury pushed a commit to juju4/cartography that referenced this issue Jun 26, 2024
@achantavy @chandan-cl
fix :lyft#1218, lyft#1152 - refactor EC2 network interface, private ip (
08fd68b 
lyft#1219)

Refactors EC2 Network Interfaces and Private IPs to the cartography data
model. Fixes lyft#1152 since the data model includes automatic cleanup jobs.

- Uses same technique as lyft#1214 to represent Network Interfaces as known
by EC2 instances vs Network Interfaces known by
describe-network-interfaces.
- Also clearly marks that the Private IPs ingested here are known by
Network Interfaces and not another source.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AWS Related to cartography's AWS module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix :#1218, #1152 - refactor EC2 network interface, private ip lyft/cartography
1 participant
@achantavy