Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AWS SSM to new data model #1216

Closed
achantavy opened this issue Jul 14, 2023 · 0 comments · Fixed by #1217
Closed

Refactor AWS SSM to new data model #1216

achantavy opened this issue Jul 14, 2023 · 0 comments · Fixed by #1217

Comments

@achantavy
Copy link
Contributor

Task: refactor the AWS SSM module to the new data model.

The SSMInstanceInformation node connects to EC2Instance nodes via instance ID and not ARN. Per #1024, we want to standardize on ARN and not instance ID. Before we do that though, we should make sure all data types involved are using the cartography data model.
achantavy added a commit that referenced this issue Jul 15, 2023
@achantavy
#1216: AWS SSM->new data model
5ae9427
@achantavy achantavy linked a pull request Jul 15, 2023 that will close this issue
#1216: AWS SSM->new data model #1217
Merged
achantavy added a commit that referenced this issue Aug 2, 2023
@achantavy @ryan-lane @ramonpetgrave64
#1216: AWS SSM->new data model (#1217)
361fc5d 
Refactors AWS SSM module to use cartography's data model.

---------

Co-authored-by: Ryan Lane <ryan.lane@paypay-corp.co.jp>
Co-authored-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
chandanchowdhury pushed a commit to juju4/cartography that referenced this issue Jun 26, 2024
@achantavy @ryan-lane
@ramonpetgrave64 @chandan-cl
lyft#1216: AWS SSM->new data model (lyft#1217)
01b0aed 
Refactors AWS SSM module to use cartography's data model.

---------

Co-authored-by: Ryan Lane <ryan.lane@paypay-corp.co.jp>
Co-authored-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1216: AWS SSM->new data model lyft/cartography
1 participant
@achantavy