Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java files autogenerated by JAXB are commited to git #199

Closed
artlog opened this issue Sep 26, 2022 · 2 comments · Fixed by #205 or #298
Closed

java files autogenerated by JAXB are commited to git #199

artlog opened this issue Sep 26, 2022 · 2 comments · Fixed by #205 or #298
Assignees
@abpai94
Labels
packaging
Milestone
2.2

Comments

@artlog
Copy link
Contributor

artlog commented Sep 26, 2022 •
edited
Loading

find src -name '*.java' | xargs grep -e '\(Généré le\)\|\(Generated on\)' | wc -l
46

source file for autogeneration main/resources/schemas/lsc-core-2.2.xsd is enough for those files
@artlog
Copy link
Contributor Author

artlog commented Sep 26, 2022

all generated file are in src/main/java/org/lsc/configuration
but some file in src/main/java/org/lsc/configuration are not autogenerated.

PivotTransformationServiceType.java is told autogenerated but is not anymore, it seems unused and a remaining file from commit 9d3431e New feature: pivot transformation (references #756).

PropertiesConfigurationHelper.java XsdForLscComparator.java JaxbXmlConfigurationHelper.java and LscConfiguration.java are the one to keep.

@artlog artlog mentioned this issue Sep 28, 2022
Merged
@coudot coudot added this to the 2.2 milestone Sep 29, 2022
@coudot coudot linked a pull request Sep 29, 2022 that will close this issue
script to ignore autogenerated files and remove them from git #205
Merged
@coudot
Copy link
Member

coudot commented Oct 12, 2023

@soisik We should revert this change and try to follow @rouazana recommandation (put generated java file in target, or at least in src/generated)

@coudot coudot assigned abpai94 and unassigned soisik Jul 12, 2024
abpai94 added a commit to Worteks/lsc that referenced this issue Jul 15, 2024
@abpai94
lsc-project#199: JAXB Sources are generated in target folder.
8250baf
@abpai94 abpai94 mentioned this issue Jul 15, 2024
Merged
@coudot coudot linked a pull request Jul 15, 2024 that will close this issue
#199: JAXB Sources are generated in target folder. #298
Merged
coudot added a commit that referenced this issue Jul 19, 2024
@coudot
Merge pull request #298 from Worteks/lsc#199
4014921 
#199: JAXB Sources are generated in target folder.
coudot added a commit that referenced this issue Jul 19, 2024
@coudot
Removed unused script (#199)
2aae221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abpai94 abpai94

Labels
packaging
Projects
None yet
Milestone
2.2
4 participants
@coudot @artlog @abpai94 @soisik