Escape arguments coming from Ruby scripts #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows you to pass in files with a space in their path, among other benefits.
|
Hi, this patch allows the ruby scripts to be used on file paths with spaces in them. If there's a problem please let me know and I'll try to correct them. |
|
Thank you. Will squash merge to unstable branch shortly after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby scripts did not work for my when I was trying the face detection example. I was doing a few things wrong, but eventually I got it to work. But only with files that didn't have spaces in the file path.
This commit escapes all the arguments being executed by the ruby scripts. Among other issues (safety) this also allows you pass the scripts images with spaces in their file paths.
http://ruby-doc.org/stdlib-2.0.0/libdoc/shellwords/rdoc/Shellwords.html