Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexik Translations cannot be edited in table, and translation.js does not install #343

Open
tom-diacono-WL opened this issue Feb 15, 2019 · 1 comment

Comments

@tom-diacono-WL
Copy link

I had a recent issue in the codebase where the translations-grid would not load, as it said that getPage.Success was deprecated. Because of this, I changed the angular version to 1.5.11 (ajax.googleapis.com/ajax/libs/angularjs/1.5.11/angular.min.js), in my grid.html.twig override file which now allows the grid to load.

The first issue I am not having however is that on a composer install, there is no js file created, and thus no translation.js file.

This can be solved by creating the directory, and copying the file from GitHub (this removes the error that I get from development console).

Unfortunately, adding the translation.js file does not fix the second issue, which is when I try and edit a translation, nothing happens. The behaviour I've been told should happen (I've not been working on this project for long so never seen it properly working) is that some of the fields should turn into textareas, however the is no reaction from the button click.

Any help would be great as I've been looking for 3 days now, and can't seem to find a fix.
Thanks in advance 👍

@tom-diacono-WL
Copy link
Author

An updated on this:
I have found that the issues I was having with saving are due to a newer version of the bundle being used, leaving our override templates out of date.

Specifically had to update the enable and disable edits. If anyone is having a similar issue please feel free to message me (although I'm sure it was just neglect on my part to check, and most will have done it).

The second issue with composer install is still unsolved. Only on my machine does it remove the translation.js file, on others machines it keeps it/updates it. We do have the same composer.json file, so not sure what else to check-> however not mission critical at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant