Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to overwrite. We need a way to reliably trigger a new write of a given iid #76

Open
jbusecke opened this issue Nov 28, 2023 · 0 comments

Comments

@jbusecke
Copy link
Collaborator

jbusecke commented Nov 28, 2023

I just noticed that the production config was setting prune to true. I think the problem is relatively contained and I implemented a really janky overwrite to fix it right now.

We should think more generally how to handle overwriting a store here.

Currently if a store has been written at all, it is not reattempted. This means if there was some small bug like the one above (which apparently also impacted #72, see #98 for manual solution attempt) these would not be automatically overwritten.

There are a few ways to handle this:

  1. Rerun all stores that fail the QC. This would be pretty easy to implement (by modifying the filtering logic here to only remove the datasets that are passing the quality control). Combined with regular retesting (and expanding tests as new bugs are discovered this would presumably take care of this issue over time. But this is really expensive! I assume we will have many datasets that are simply 'broken' at the moment and might never pass the tests. We would rerun these again and again creating a lot of cost.
  2. Alternatively we could implement a 'one-time' trigger to overwrite all or a set of iids. Currently I have added selected iids to the recipe directly, but they will be rerun every time the recipe is run, which is not ideal. Curious to discuss this.
@jbusecke jbusecke changed the title We need a way to reliably trigger a new write of a given iid How to overwrite. We need a way to reliably trigger a new write of a given iid Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant