From e768a3fbd2f2e18d67be4e3efa5064873be1a4cf Mon Sep 17 00:00:00 2001 From: Konboi Date: Tue, 12 Sep 2023 14:35:41 +0900 Subject: [PATCH 1/7] update version --- .github/workflows/e2e.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index 54a1098..d125e3b 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -21,11 +21,11 @@ jobs: python-version: [3.6, 3.7, 3.8] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} From b87d8644554dd42c6201c68570e9b5354c478a82 Mon Sep 17 00:00:00 2001 From: Konboi Date: Tue, 12 Sep 2023 14:39:37 +0900 Subject: [PATCH 2/7] introduce retry action --- .github/workflows/e2e.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index d125e3b..a04f4f2 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -30,9 +30,11 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install -r test-requirements.txt + uses: nick-fields/retry@v2 + with: + max_attempts: 3 + retry_on: error + command: python -m pip install --upgrade pip && pip install -r test-requirements.txt working-directory: ./e2e - name: Preapre tests run: | From c7a4834020886ff8b139b5b27ca76a85882d24c4 Mon Sep 17 00:00:00 2001 From: Konboi Date: Tue, 12 Sep 2023 14:50:21 +0900 Subject: [PATCH 3/7] retry action doesn't support working-directory and set timeout minutes --- .github/workflows/e2e.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index a04f4f2..b2ee1b7 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -33,9 +33,13 @@ jobs: uses: nick-fields/retry@v2 with: max_attempts: 3 + timeout_minutes: 5 retry_on: error - command: python -m pip install --upgrade pip && pip install -r test-requirements.txt - working-directory: ./e2e + command: | + cd ./e2e + python -m pip install wheel + python -m pip install --upgrade pip + pip install -r test-requirements.txt - name: Preapre tests run: | launchable record build --name ${GITHUB_RUN_ID} @@ -44,7 +48,6 @@ jobs: run: | python runner.py working-directory: ./e2e - - uses: actions/checkout@v2 - name: slack notify if: failure() uses: rtCamp/action-slack-notify@v2 From 0dba218d640023f312c0867cf5922aeb8b9f3713 Mon Sep 17 00:00:00 2001 From: Konboi Date: Tue, 12 Sep 2023 14:55:43 +0900 Subject: [PATCH 4/7] update --- .github/workflows/test.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 479ee6e..6a440bc 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -23,11 +23,11 @@ jobs: python-version: [3.5, 3.6, 3.7, 3.8] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} - name: Set up JDK 1.8 @@ -36,6 +36,8 @@ jobs: java-version: 1.8 - name: Install dependencies run: | + # see: https://github.com/pypa/pip/issues/11972 + python -m pip install wheel python -m pip install --upgrade pip pip install -r test-requirements.txt pip install -r requirements.txt From cda8ad36eff52e12d04f59b180c13df41ba06cf2 Mon Sep 17 00:00:00 2001 From: Konboi Date: Tue, 12 Sep 2023 15:39:17 +0900 Subject: [PATCH 5/7] install retry too --- .github/workflows/test.yaml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6a440bc..6d29b99 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -35,13 +35,18 @@ jobs: with: java-version: 1.8 - name: Install dependencies - run: | - # see: https://github.com/pypa/pip/issues/11972 - python -m pip install wheel - python -m pip install --upgrade pip - pip install -r test-requirements.txt - pip install -r requirements.txt - pip install -e . + uses: nick-fields/retry@v2 + with: + max_attempts: 3 + timeout_minutes: 5 + retry_on: error + command: | + # see: https://github.com/pypa/pip/issues/11972 + python -m pip install wheel + python -m pip install --upgrade pip + pip install -r test-requirements.txt + pip install -r requirements.txt + pip install -e . - name: Lint with flake8 run: | # stop the build if there are Python syntax errors or undefined names From b7fc658b62121f789518be3ce8f5745415238645 Mon Sep 17 00:00:00 2001 From: Konboi Date: Thu, 12 Oct 2023 11:56:02 +0900 Subject: [PATCH 6/7] use commit hash --- .github/workflows/e2e.yaml | 8 ++++---- .github/workflows/test.yaml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index b2ee1b7..d4e7598 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -21,16 +21,16 @@ jobs: python-version: [3.6, 3.7, 3.8] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 with: fetch-depth: 0 - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v4 + uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1 with: python-version: ${{ matrix.python-version }} - name: Install dependencies - uses: nick-fields/retry@v2 + uses: nick-fields/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # v2.9.0 with: max_attempts: 3 timeout_minutes: 5 @@ -50,7 +50,7 @@ jobs: working-directory: ./e2e - name: slack notify if: failure() - uses: rtCamp/action-slack-notify@v2 + uses: rtCamp/action-slack-notify@b24d75fe0e728a4bf9fc42ee217caa686d141ee8 # v2.2.1 env: SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} SLACK_ICON_EMOJI: ":rotating_light:" diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6d29b99..d685fd8 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -23,19 +23,19 @@ jobs: python-version: [3.5, 3.6, 3.7, 3.8] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 with: fetch-depth: 0 - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v4 + uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1 with: python-version: ${{ matrix.python-version }} - name: Set up JDK 1.8 - uses: actions/setup-java@v1 + uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0 # v3.13.0 with: java-version: 1.8 - name: Install dependencies - uses: nick-fields/retry@v2 + uses: nick-fields/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # v2.9.0 with: max_attempts: 3 timeout_minutes: 5 From ff55393281c72f681bae40422348a27321781e4a Mon Sep 17 00:00:00 2001 From: Konboi Date: Thu, 12 Oct 2023 12:04:14 +0900 Subject: [PATCH 7/7] set distribution and changed version format from v2 distribution field is required --- .github/workflows/test.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index d685fd8..662e471 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -33,7 +33,8 @@ jobs: - name: Set up JDK 1.8 uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0 # v3.13.0 with: - java-version: 1.8 + java-version: 8 + distribution: 'adopt' - name: Install dependencies uses: nick-fields/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # v2.9.0 with: